tidy configs

dataset_infos.json

@@ -1 +1 @@
-{"illustration_detection": {"description": "TODO", "citation": "TODO", "homepage": "TODO", "license": "Public Domain Mark 1.0", "features": {"image_id": {"dtype": "int64", "id": null, "_type": "Value"}, "image": {"decode": true, "id": null, "_type": "Image"}, "width": {"dtype": "int32", "id": null, "_type": "Value"}, "height": {"dtype": "int32", "id": null, "_type": "Value"}, "objects": [{"category_id": {"num_classes": 1, "names": ["early_printed_illustration"], "id": null, "_type": "ClassLabel"}, "image_id": {"dtype": "string", "id": null, "_type": "Value"}, "id": {"dtype": "int64", "id": null, "_type": "Value"}, "area": {"dtype": "int64", "id": null, "_type": "Value"}, "bbox": {"feature": {"dtype": "float32", "id": null, "_type": "Value"}, "length": 4, "id": null, "_type": "Sequence"}, "segmentation": [[{"dtype": "float32", "id": null, "_type": "Value"}]], "iscrowd": {"dtype": "bool", "id": null, "_type": "Value"}}]}, "post_processed": null, "supervised_keys": null, "task_templates": null, "builder_name": "nls_chapbook_illustrations", "config_name": "illustration_detection", "version": {"version_str": "1.0.0", "description": null, "major": 1, "minor": 0, "patch": 0}, "splits": {"train": {"name": "train", "num_bytes": 1861271, "num_examples": 7258, "dataset_name": "nls_chapbook_illustrations"}}, "download_checksums": {"https://nlsfoundry.s3.amazonaws.com/data/nls-data-chapbooks.zip": {"num_bytes": 6754994277, "checksum": "ead1ce3f59ad561025235656848024049bae635eadb7e191048bc990d32e85f8"}, "https://gitlab.com/davanstrien/nls-chapbooks-illustrations/-/raw/master/data/annotations/step5-manual-verification-image-0-47329_train_coco.json": {"num_bytes": 1860557, "checksum": "edfbdaa4123c40b8a90472e5ab7664b9e22c25cdfbf1a0925f5820e5cc4d4275"}}, "download_size": 6756854834, "post_processing_size": null, "dataset_size": 1861271, "size_in_bytes": 6758716105}, "image_classification": {"description": "TODO", "citation": "TODO", "homepage": "TODO", "license": "Public Domain Mark 1.0", "features": {"image": {"decode": true, "id": null, "_type": "Image"}, "label": {"num_classes": 2, "names": ["not-illustrated", "illustrated"], "id": null, "_type": "ClassLabel"}}, "post_processed": null, "supervised_keys": null, "task_templates": null, "builder_name": "nls_chapbook_illustrations", "config_name": "image_classification", "version": {"version_str": "1.0.0", "description": null, "major": 1, "minor": 0, "patch": 0}, "splits": {"train": {"name": "train", "num_bytes": 1430734, "num_examples": 7258, "dataset_name": "nls_chapbook_illustrations"}}, "download_checksums": {"https://nlsfoundry.s3.amazonaws.com/data/nls-data-chapbooks.zip": {"num_bytes": 6754994277, "checksum": "ead1ce3f59ad561025235656848024049bae635eadb7e191048bc990d32e85f8"}, "https://gitlab.com/davanstrien/nls-chapbooks-illustrations/-/raw/master/data/annotations/step5-manual-verification-image-0-47329_train_coco.json": {"num_bytes": 1860557, "checksum": "edfbdaa4123c40b8a90472e5ab7664b9e22c25cdfbf1a0925f5820e5cc4d4275"}}, "download_size": 6756854834, "post_processing_size": null, "dataset_size": 1430734, "size_in_bytes": 6758285568}}
+{"illustration_detection": {"description": "TODO", "citation": "TODO", "homepage": "TODO", "license": "Public Domain Mark 1.0", "features": {"image_id": {"dtype": "int64", "id": null, "_type": "Value"}, "image": {"decode": true, "id": null, "_type": "Image"}, "width": {"dtype": "int32", "id": null, "_type": "Value"}, "height": {"dtype": "int32", "id": null, "_type": "Value"}, "objects": [{"category_id": {"num_classes": 1, "names": ["early_printed_illustration"], "id": null, "_type": "ClassLabel"}, "image_id": {"dtype": "string", "id": null, "_type": "Value"}, "id": {"dtype": "int64", "id": null, "_type": "Value"}, "area": {"dtype": "int64", "id": null, "_type": "Value"}, "bbox": {"feature": {"dtype": "float32", "id": null, "_type": "Value"}, "length": 4, "id": null, "_type": "Sequence"}, "segmentation": [[{"dtype": "float32", "id": null, "_type": "Value"}]], "iscrowd": {"dtype": "bool", "id": null, "_type": "Value"}}]}, "post_processed": null, "supervised_keys": null, "task_templates": null, "builder_name": "nls_chapbook_illustrations", "config_name": "illustration_detection", "version": {"version_str": "1.0.0", "description": null, "major": 1, "minor": 0, "patch": 0}, "splits": {"train": {"name": "train", "num_bytes": 1861271, "num_examples": 7258, "dataset_name": "nls_chapbook_illustrations"}}, "download_checksums": {"https://nlsfoundry.s3.amazonaws.com/data/nls-data-chapbooks.zip": {"num_bytes": 6754994277, "checksum": "ead1ce3f59ad561025235656848024049bae635eadb7e191048bc990d32e85f8"}, "https://gitlab.com/davanstrien/nls-chapbooks-illustrations/-/raw/master/data/annotations/step5-manual-verification-image-0-47329_train_coco.json": {"num_bytes": 1860557, "checksum": "edfbdaa4123c40b8a90472e5ab7664b9e22c25cdfbf1a0925f5820e5cc4d4275"}}, "download_size": 6756854834, "post_processing_size": null, "dataset_size": 1861271, "size_in_bytes": 6758716105}, "image_classification": {"description": "TODO", "citation": "TODO", "homepage": "TODO", "license": "Public Domain Mark 1.0", "features": {"image": {"decode": true, "id": null, "_type": "Image"}, "label": {"num_classes": 2, "names": ["not-illustrated", "illustrated"], "id": null, "_type": "ClassLabel"}}, "post_processed": null, "supervised_keys": null, "task_templates": null, "builder_name": "nls_chapbook_illustrations", "config_name": "image_classification", "version": {"version_str": "1.0.0", "description": null, "major": 1, "minor": 0, "patch": 0}, "splits": {"train": {"name": "train", "num_bytes": 1430734, "num_examples": 7258, "dataset_name": "nls_chapbook_illustrations"}}, "download_checksums": {"https://nlsfoundry.s3.amazonaws.com/data/nls-data-chapbooks.zip": {"num_bytes": 6754994277, "checksum": "ead1ce3f59ad561025235656848024049bae635eadb7e191048bc990d32e85f8"}, "https://gitlab.com/davanstrien/nls-chapbooks-illustrations/-/raw/master/data/annotations/step5-manual-verification-image-0-47329_train_coco.json": {"num_bytes": 1860557, "checksum": "edfbdaa4123c40b8a90472e5ab7664b9e22c25cdfbf1a0925f5820e5cc4d4275"}}, "download_size": 6756854834, "post_processing_size": null, "dataset_size": 1430734, "size_in_bytes": 6758285568}, "illustration-detection": {"description": "TODO", "citation": "TODO", "homepage": "TODO", "license": "Public Domain Mark 1.0", "features": {"image_id": {"dtype": "int64", "id": null, "_type": "Value"}, "image": {"decode": true, "id": null, "_type": "Image"}, "width": {"dtype": "int32", "id": null, "_type": "Value"}, "height": {"dtype": "int32", "id": null, "_type": "Value"}, "objects": [{"category_id": {"num_classes": 1, "names": ["early_printed_illustration"], "id": null, "_type": "ClassLabel"}, "image_id": {"dtype": "string", "id": null, "_type": "Value"}, "id": {"dtype": "int64", "id": null, "_type": "Value"}, "area": {"dtype": "int64", "id": null, "_type": "Value"}, "bbox": {"feature": {"dtype": "float32", "id": null, "_type": "Value"}, "length": 4, "id": null, "_type": "Sequence"}, "segmentation": [[{"dtype": "float32", "id": null, "_type": "Value"}]], "iscrowd": {"dtype": "bool", "id": null, "_type": "Value"}}]}, "post_processed": null, "supervised_keys": null, "task_templates": null, "builder_name": "nls_chapbook_illustrations", "config_name": "illustration-detection", "version": {"version_str": "1.0.0", "description": null, "major": 1, "minor": 0, "patch": 0}, "splits": {"train": {"name": "train", "num_bytes": 1861271, "num_examples": 7258, "dataset_name": "nls_chapbook_illustrations"}}, "download_checksums": {"https://nlsfoundry.s3.amazonaws.com/data/nls-data-chapbooks.zip": {"num_bytes": 6754994277, "checksum": "ead1ce3f59ad561025235656848024049bae635eadb7e191048bc990d32e85f8"}, "https://gitlab.com/davanstrien/nls-chapbooks-illustrations/-/raw/master/data/annotations/step5-manual-verification-image-0-47329_train_coco.json": {"num_bytes": 1860557, "checksum": "edfbdaa4123c40b8a90472e5ab7664b9e22c25cdfbf1a0925f5820e5cc4d4275"}}, "download_size": 6756854834, "post_processing_size": null, "dataset_size": 1861271, "size_in_bytes": 6758716105}, "image-classification": {"description": "TODO", "citation": "TODO", "homepage": "TODO", "license": "Public Domain Mark 1.0", "features": {"image": {"decode": true, "id": null, "_type": "Image"}, "label": {"num_classes": 2, "names": ["not-illustrated", "illustrated"], "id": null, "_type": "ClassLabel"}}, "post_processed": null, "supervised_keys": null, "task_templates": null, "builder_name": "nls_chapbook_illustrations", "config_name": "image-classification", "version": {"version_str": "1.0.0", "description": null, "major": 1, "minor": 0, "patch": 0}, "splits": {"train": {"name": "train", "num_bytes": 1430734, "num_examples": 7258, "dataset_name": "nls_chapbook_illustrations"}}, "download_checksums": {"https://nlsfoundry.s3.amazonaws.com/data/nls-data-chapbooks.zip": {"num_bytes": 6754994277, "checksum": "ead1ce3f59ad561025235656848024049bae635eadb7e191048bc990d32e85f8"}, "https://gitlab.com/davanstrien/nls-chapbooks-illustrations/-/raw/master/data/annotations/step5-manual-verification-image-0-47329_train_coco.json": {"num_bytes": 1860557, "checksum": "edfbdaa4123c40b8a90472e5ab7664b9e22c25cdfbf1a0925f5820e5cc4d4275"}}, "download_size": 6756854834, "post_processing_size": null, "dataset_size": 1430734, "size_in_bytes": 6758285568}}

nls_chapbook_illustrations.py

@@ -20,7 +20,6 @@ from typing import Any, Dict, List
 
 import datasets
 
-
 _CITATION = "TODO"
 
 
@@ -38,6 +37,8 @@ _IMAGES_URL = "https://nlsfoundry.s3.amazonaws.com/data/nls-data-chapbooks.zip"
 # TODO update url if this is merged upstream
 _ANNOTATIONS_URL = "https://gitlab.com/davanstrien/nls-chapbooks-illustrations/-/raw/master/data/annotations/step5-manual-verification-image-0-47329_train_coco.json"
 
+logger = datasets.utils.logging.get_logger(__name__)
+
 
 class NationalLibraryScotlandChapBooksConfig(datasets.BuilderConfig):
     """BuilderConfig for National Library of Scotland Chapbooks dataset."""
@@ -55,19 +56,18 @@ class NationalLibraryScotlandChapBooks(datasets.GeneratorBasedBuilder):
     """National Library of Scotland Chapbooks dataset."""
 
     BUILDER_CONFIGS = [
-        NationalLibraryScotlandChapBooksConfig("illustration_detection"),
-        NationalLibraryScotlandChapBooksConfig("image_classification"),
+        NationalLibraryScotlandChapBooksConfig("illustration-detection"),
+        NationalLibraryScotlandChapBooksConfig("image-classification"),
     ]
 
     def _info(self):
-        if self.config.name == "illustration_detection":
+        if self.config.name == "illustration-detection":
             features = datasets.Features(
                 {
                     "image_id": datasets.Value("int64"),
                     "image": datasets.Image(),
                     "width": datasets.Value("int32"),
                     "height": datasets.Value("int32"),
-                 #   "url": datasets.Value("string"),
                 }
             )
             object_dict = {
@@ -82,7 +82,7 @@ class NationalLibraryScotlandChapBooks(datasets.GeneratorBasedBuilder):
                 "iscrowd": datasets.Value("bool"),
             }
             features["objects"] = [object_dict]
-        if self.config.name == "image_classification":
+        if self.config.name == "image-classification":
             features = datasets.Features(
                 {
                     "image": datasets.Image(),
@@ -131,7 +131,6 @@ class NationalLibraryScotlandChapBooks(datasets.GeneratorBasedBuilder):
                 "image": os.path.join(image_dir, image),
                 "width": image_info["width"],
                 "height": image_info["height"],
-              #  "url": image_info.get("url"),
             }
 
         with open(annotations_file, encoding="utf8") as f:
@@ -142,7 +141,7 @@ class NationalLibraryScotlandChapBooks(datasets.GeneratorBasedBuilder):
             image_id_to_annotations = self._get_image_id_to_annotations_mapping(
                 annotations
             )
-            if self.config.name == "illustration_detection":
+            if self.config.name == "illustration-detection":
                 for idx, image_info in enumerate(images):
                     example = _image_info_to_example(
                         image_info,
@@ -157,9 +156,8 @@ class NationalLibraryScotlandChapBooks(datasets.GeneratorBasedBuilder):
                         objects.append(annot)
                     example["objects"] = objects
                     yield idx, example
-            if self.config.name == "image_classification":
+            if self.config.name == "image-classification":
                 for idx, image_info in enumerate(images):
-                    example = _image_info_to_example(image_info, image_dir)
                     annotations = image_id_to_annotations[image_info["id"]]
                     if len(annotations) < 1:
                         label = 0